[#338] enable reresolution work around based on jaxb-ri used

highsource · Nov 22, 2023 · a3d9f80 · a3d9f80
1 parent 6eb2982
commit a3d9f80
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 8 deletions.
diff --git a/maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/AbstractXJCMojo.java b/maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/AbstractXJCMojo.java
@@ -444,7 +444,8 @@ public void setCatalogResolver(String catalogResolver) {
     /**
      * If 'true', the fix for issue #306 will no more be applied.
      */
-    @Parameter(defaultValue = "false", property = "maven.xjc2.disableSystemIdResolution")
+    @Parameter(defaultValue = "true", property = "maven.xjc2.disableSystemIdResolution")
+    @Deprecated(forRemoval = true, since = "4.0.1")
     private boolean disableSystemIdResolution;
 
     public boolean getDisableSystemIdResolution() {

diff --git a/maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/RawXJCMojo.java b/maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/RawXJCMojo.java
@@ -893,7 +893,7 @@ private void setupEntityResolver() {
 	}
 
 	protected EntityResolver createEntityResolver(CatalogResolver catalogResolver) {
-		final EntityResolver entityResolver = new ReResolvingEntityResolverWrapper(catalogResolver, getLog(), getDisableSystemIdResolution());
+		final EntityResolver entityResolver = new ReResolvingEntityResolverWrapper(catalogResolver, getLog(), getDisableSystemIdResolution(), getVersion());
 		return entityResolver;
 	}
 

diff --git a/...e/src/main/java/org/jvnet/jaxb/maven/resolver/tools/ReResolvingEntityResolverWrapper.java b/...e/src/main/java/org/jvnet/jaxb/maven/resolver/tools/ReResolvingEntityResolverWrapper.java
@@ -5,6 +5,7 @@
 import java.util.Optional;
 
 import org.apache.maven.plugin.logging.Log;
+import org.jvnet.jaxb.maven.XJCVersion;
 import org.jvnet.jaxb.maven.plugin.logging.NullLog;
 import org.jvnet.jaxb.maven.util.StringUtils;
 import org.xml.sax.EntityResolver;
@@ -17,21 +18,41 @@ public class ReResolvingEntityResolverWrapper implements EntityResolver {
     private final Log log;
     private final boolean disableSystemIdResolution;
 
-	public ReResolvingEntityResolverWrapper(EntityResolver entityResolver, Log log, boolean disableSystemIdResolution) {
+	public ReResolvingEntityResolverWrapper(EntityResolver entityResolver, Log log, boolean disableSystemIdResolution, XJCVersion version) {
 		if (entityResolver == null) {
 			throw new IllegalArgumentException("Provided entity resolver must not be null.");
 		}
 		this.entityResolver = entityResolver;
 		this.log = Optional.ofNullable(log).orElse(NullLog.INSTANCE);
-        this.disableSystemIdResolution = disableSystemIdResolution;
-        if (disableSystemIdResolution) {
-            log.warn("ReResolvingEntityResolverWrapper : systemIdResolution fix is disable, you may have problems with schema resolution.");
+        this.disableSystemIdResolution = computeDisableSystemIdResolution(disableSystemIdResolution, version);
+	}
+
+    private boolean computeDisableSystemIdResolution(boolean disableSystemIdResolution, XJCVersion version) {
+        boolean finalDisableSystemIdResolution = disableSystemIdResolution;
+        boolean versionCheck = false;
+        if (version.isKnown()) {
+            versionCheck = true;
+            if (version.gte(4, 0, 4) && !disableSystemIdResolution) {
+                log.info("ReResolvingEntityResolverWrapper : systemIdResolution fix has been auto-disabled (current running XJC is " + version.getRaw() + ").");
+                finalDisableSystemIdResolution = true;
+            } else if (version.gte(4, 0, 0) && version.lt(4, 0, 4) && disableSystemIdResolution) {
+                log.info("ReResolvingEntityResolverWrapper : systemIdResolution fix has been auto-enabled (current running XJC is " + version.getRaw() + ").");
+                finalDisableSystemIdResolution = false;
+            }
+        }
+        if (finalDisableSystemIdResolution) {
+            if (!versionCheck) {
+                log.warn("ReResolvingEntityResolverWrapper : systemIdResolution fix is disable, you may have problems with schema resolution.");
+            } else {
+                log.debug("ReResolvingEntityResolverWrapper : systemIdResolution fix is disabled");
+            }
         } else {
             log.debug("ReResolvingEntityResolverWrapper : systemIdResolution fix is enabled");
         }
-	}
+        return finalDisableSystemIdResolution;
+    }
 
-	@Override
+    @Override
 	public InputSource resolveEntity(String publicId, String systemId)
 			throws SAXException, IOException {
 		log.debug(MessageFormat.format("ReResolvingEntityResolverWrapper : Resolving publicId [{0}], systemId [{1}].", publicId, systemId));