-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(build) Add Subresource Integrity digests for CDN builds #2892
enh(build) Add Subresource Integrity digests for CDN builds #2892
Conversation
It might be nice to include digest more prominently in the README.me but then we get into reproducable build issues (I'd hope they are, but who knows - right now the canonical version is whatever is build by GHA during Seems better to me to always keep this information in a version keyed resource, like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm going blind, where is ./tools/templates/DIGESTS.md
located?
Co-authored-by: Vladimir Jimenez <[email protected]>
…ht.js into subresource_integrity
Co-authored-by: Vladimir Jimenez <[email protected]>
Co-authored-by: Vladimir Jimenez <[email protected]>
Co-authored-by: Vladimir Jimenez <[email protected]>
Better? |
Makes the following changes:
DIGESTS.md
file for CDN builds with simple instructionsrelease
script to moveDIGESTS.md
to root of cdn-asset repoREADME.md
to mention SRI and link toDIGESTS.md
IE, we don't actuall publish
DIGESTS.md
to the CDNs, but it's availablein the repo for anyone who wants to use it to know what the digests are.
Changes
Checklist
CHANGES.md
AUTHORS.txt
, under Contributors