Bugfix: Ignore empty discount/addon arrays #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Braintree API is just fine with accepting an empty array – so FakeBraintree
should be fine with this as well.
Example:
Braintree::Subscription.update(subscription_id, discounts: {
add: [],
update: [{ existing_id: some_id, amount: some_amount }]
})
This previously failed because FakeBraintree would stop at the `add` key since
it can be found and isn't nil. After this patch, FakeBraintree continues on the
empty array and correctly updates the discount.
| @@ -152,6 +152,17 @@ | |||
| expect(discounts.first.quantity).to eq 5 | |||
| end | |||
|
|
|||
| it 'updates an existing discount if an empty :add array is given' do | |||
| discount_id = 'abc123' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Any feedback on this? |
|
Sorry @clemens been a bit behind on fake_braintree stuff. Merging! |
birarda
added a commit
that referenced
this pull request
Dec 8, 2015
Bugfix: Ignore empty discount/addon arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Braintree API is just fine with accepting an empty array – so FakeBraintree
should be fine with this as well.
Example:
This previously failed because FakeBraintree would stop at the
addkey sinceit can be found and isn't nil. After this patch, FakeBraintree continues on the
empty array and correctly updates the discount.