Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: highfidelity/fake_braintree
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.0
Choose a base ref
...
head repository: highfidelity/fake_braintree
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 6 commits
  • 12 files changed
  • 3 contributors

Commits on Nov 19, 2015

  1. Bugfix: Ignore empty discount/addon arrays

    The Braintree API is just fine with accepting an empty array – so FakeBraintree
    should be fine with this as well.
    
    Example:
    
    Braintree::Subscription.update(subscription_id, discounts: {
    	add: [],
    	update: [{ existing_id: some_id, amount: some_amount }]
    })
    
    This previously failed because FakeBraintree would stop at the `add` key since
    it can be found and isn't nil. After this patch, FakeBraintree continues on the
    empty array and correctly updates the discount.
    Clemens Kofler committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    cc82653 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2015

  1. Merge pull request #109 from clemens/bugfix/ignore-empty-discounts-array

    Bugfix: Ignore empty discount/addon arrays
    birarda committed Dec 8, 2015
    Configuration menu
    Copy the full SHA
    5f5aae1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2015

  1. Bugfix: Ensure creation time is set when records are created

    According go the API docs, pretty much every record in the Braintree API has a created_at field – so we should have them as well.
    Clemens Kofler committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    c8bea45 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2016

  1. Merge pull request #112 from clemens/bugfix/ensure-creation-time-is-s…

    …et-when-records-are-created
    
    Bugfix: Ensure creation time is set when records are created
    birarda committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    630217c View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2016

  1. Fixed broken spec.

    Braintree::PaymentMethod.delete returns success object instead of boolean
    Manjot Sangha committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    42ff29b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2016

  1. Merge pull request #115 from finventures/ms-fixed-failing-test

    Fixed broken spec
    birarda authored Aug 12, 2016
    Configuration menu
    Copy the full SHA
    2a7f517 View commit details
    Browse the repository at this point in the history
Loading