Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for this library — we're investigating using it on https://svelte.dev/playground.
As you can see on the PR, we needed to add a
declare module
declaration in order to use it with type safety, and the declaration files are quite large (and prone to get out of date). Since you've already gone to the trouble of annotating everything with JSDoc comments, I wondered if you'd be open to a smallprepublishOnly
script that generates.d.ts
files automatically?It does introduce a devDependency on
typescript
, which I recognise isn't everyone's cup of tea. But it allows users of this library to get autocomplete and inline documentation and type safety, and also helps to ensure that this package remains bug-free (e.g. you'll notice TypeScript caught a small discrepancy in thetype
field).Thank you for your consideration!