Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark initializer rewrite #463

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

bcomnes
Copy link
Member

@bcomnes bcomnes commented Dec 15, 2024

This PR rewrites the bookmark initializer worker to initialize bookmarks using all available metadata sources. It also changes automatic resource creation (Archives, Episodes) to only happen if there is something to save. It also begins to formalize the URL normalization process across various features.

Copy link

socket-security bot commented Dec 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@bret/[email protected] None 0 14.4 kB bret
npm/@mozilla/[email protected] None 0 149 kB gijs
npm/@types/[email protected] None 0 3.96 kB types
npm/@types/[email protected] None 0 1.74 kB types
npm/@types/[email protected] None 0 2.93 kB types
npm/@types/[email protected] None 0 7.11 kB types
npm/[email protected] None +2 30.3 kB mafintosh
npm/[email protected] None +1 314 kB cure53
npm/[email protected] environment Transitive: filesystem +29 1.11 MB matteo.collina
npm/[email protected] None +2 129 kB smartiniatnpm
npm/[email protected] Transitive: filesystem, network, unsafe +1 181 kB m03geek
npm/[email protected] None 0 41.3 kB eomm
npm/[email protected] Transitive: eval +24 5.04 MB eomm
npm/[email protected] None +18 1.01 MB mafintosh
npm/[email protected] None +1 20.9 kB matteo.collina
npm/[email protected] eval, filesystem, network, shell, unsafe Transitive: environment +30 6.27 MB domenic
npm/[email protected] environment, eval Transitive: filesystem, shell +47 5.68 MB webpro
npm/[email protected] None 0 80 kB isaacs
npm/[email protected] None 0 22.7 MB typescript-bot
npm/[email protected] environment, network 0 1.3 MB matteo.collina
npm/[email protected] None 0 3.28 MB intoli

🚮 Removed packages: npm/@breadcrum/[email protected], npm/@bull-board/[email protected], npm/@bull-board/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Dec 15, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Native code npm/[email protected] 🚫

View full report↗︎

Next steps

Why is native code a concern?

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@bcomnes bcomnes force-pushed the bookmark-initializer-rewrite branch 4 times, most recently from 473fe9f to 3c1618c Compare December 31, 2024 23:39
WIP

WIP

# Conflicts:
#	packages/worker/package.json
#	packages/worker/workers/bookmark-initializer/index.js

Deps

WIP

Refactor PgClient types

WIP
@bcomnes bcomnes force-pushed the bookmark-initializer-rewrite branch from 3c1618c to 29b479b Compare January 1, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant