fix: incomplete file append transaction #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Svetoslav Borislavov <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
+ Coverage 84.45% 84.47% +0.01%
==========================================
Files 283 283
Lines 71088 71083 -5
==========================================
+ Hits 60037 60046 +9
+ Misses 11051 11037 -14 ☔ View full report in Codecov by Sentry. |
ivaylonikolov7
approved these changes
Oct 22, 2024
agadzhalov
approved these changes
Oct 24, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request fixes the FileAppendTransaction when building an incomplete transaction and you don't want to set contents. Previously the contents were required and you couldn't create incomplete transactions without setting the content.
Checklist