Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not override service port #2106

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 28, 2024

Description:

This PR fixes Endpoint overriding the port if it is 0 or 50111

Related issue(s):

Fixes #2098

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov self-assigned this Nov 28, 2024
@0xivanov 0xivanov requested a review from a team as a code owner November 28, 2024 11:08
@0xivanov 0xivanov requested a review from agadzhalov November 28, 2024 11:08
Signed-off-by: Ivan Ivanov <[email protected]>
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 914af7f into main Nov 29, 2024
11 checks passed
@0xivanov 0xivanov deleted the 2098-ServiceEndpoint-port-gets-overwritten branch November 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceEndpoint port gets overwritten
2 participants