Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NodeUpdateTransaction sets description as empty string #2096

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

0xivanov
Copy link
Contributor

Description:

Related issue(s):

Fixes #2091

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov self-assigned this Nov 22, 2024
@0xivanov 0xivanov requested a review from a team as a code owner November 22, 2024 07:45
@0xivanov 0xivanov requested a review from SimiHunjan November 22, 2024 07:45
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jbair06 jbair06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done so quickly! Looks great

@0xivanov 0xivanov merged commit e5abcca into main Nov 22, 2024
11 checks passed
@0xivanov 0xivanov deleted the node-update-fix-null-description branch November 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeCreate and NodeUpdate have nullable fields that cannot be set to null
3 participants