Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplified ipv4 address #1970

Merged
merged 3 commits into from
Sep 25, 2024
Merged

feat: Simplified ipv4 address #1970

merged 3 commits into from
Sep 25, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Aug 27, 2024

Description:
IPv4 addresses would typically be represented as four octets (bytes), no two parts (network and host). While it's possible to divide an IPv4 address into network and host parts, the representation here is non-standard.

Related issue(s):

Fixes #1969

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the enhancement New feature or request label Aug 27, 2024
@0xivanov 0xivanov self-assigned this Aug 27, 2024
Copy link

@0xivanov 0xivanov marked this pull request as ready for review September 25, 2024 07:51
@0xivanov 0xivanov requested a review from a team as a code owner September 25, 2024 07:51
@0xivanov 0xivanov requested a review from thenswan September 25, 2024 07:51
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit d3f2483 into main Sep 25, 2024
12 checks passed
@0xivanov 0xivanov deleted the simlify-ipv4address branch September 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate non-standart ipv4 addresses
2 participants