Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UpdateNftsMetadataExample.java #1783

Conversation

SimiHunjan
Copy link
Contributor

Description:

  • Added comments to describe the steps alongside the code snippets in the example
  • Removed the need to do a token association since the account we created has set max automatic associations to 10

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: SimiHunjan <[email protected]>

Signed-off-by: SimiHunjan <[email protected]>
@agadzhalov agadzhalov requested review from svetoslav-nikol0v and removed request for svetoslav-nikol0v April 22, 2024 05:07
Signed-off-by: Nikita Lebedev <[email protected]>
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thenswan thenswan merged commit d3d9141 into 01496-add-hip-657-mutable-metadata-fields-for-dynamic-nfts Apr 23, 2024
3 checks passed
@thenswan thenswan deleted the update-NFT-metadata-example branch April 23, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants