Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: execute can ignore timeout and block indefinitely #1188

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Oct 19, 2022

Description:

This PR reverts some changes from #1091 in order to fix block when running tests in CI

Related issue(s):

Fixes #1175

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 71.80% // Head: 71.75% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (9c8a1db) compared to base (2da5aa4).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1188      +/-   ##
============================================
- Coverage     71.80%   71.75%   -0.05%     
+ Complexity     2663     2659       -4     
============================================
  Files           184      184              
  Lines         11320    11334      +14     
  Branches       1111     1113       +2     
============================================
+ Hits           8128     8133       +5     
- Misses         2550     2554       +4     
- Partials        642      647       +5     
Impacted Files Coverage Δ
...src/main/java/com/hedera/hashgraph/sdk/Client.java 64.15% <93.33%> (+1.32%) ⬆️
...c/main/java/com/hedera/hashgraph/sdk/BaseNode.java 75.29% <0.00%> (-2.36%) ⬇️
...main/java/com/hedera/hashgraph/sdk/Executable.java 76.38% <0.00%> (-2.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dikel dikel requested review from nikola-genov and ochikov October 20, 2022 08:16
@ochikov ochikov merged commit 961f3c0 into main Oct 21, 2022
@ochikov ochikov deleted the fix/execute-can-ignore-timeout-and-block branch October 21, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute with a timeout can ignore timeout and block indefinitely
3 participants