Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve android example #1173

Merged
merged 15 commits into from
Oct 26, 2022
Merged

Improve android example #1173

merged 15 commits into from
Oct 26, 2022

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Oct 4, 2022

Description:

  • Make the Android example use the Maven Central version by default
  • Add instructions for running it with the local SDK version

Related issue(s):

Fixes #1105

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 71.77% // Head: 71.77% // No change to project coverage 👍

Coverage data is based on head (6226a5f) compared to base (aea5145).
Patch has no changes to coverable lines.

❗ Current head 6226a5f differs from pull request most recent head f8f3300. Consider uploading reports for the commit f8f3300 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1173   +/-   ##
==========================================
  Coverage      71.77%   71.77%           
  Complexity      2660     2660           
==========================================
  Files            184      184           
  Lines          11334    11334           
  Branches        1113     1113           
==========================================
  Hits            8135     8135           
  Misses          2553     2553           
  Partials         646      646           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dikel dikel force-pushed the improve-android-example branch from ec7ac93 to bb05f71 Compare October 4, 2022 08:09
@stoqnkpL stoqnkpL requested a review from nathanklick October 4, 2022 08:57
@nathanklick nathanklick mentioned this pull request Oct 6, 2022
2 tasks
@dikel dikel requested a review from ochikov October 14, 2022 09:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dikel dikel changed the base branch from main to develop October 24, 2022 10:06
dikel and others added 14 commits October 26, 2022 10:24
…a script for running it with the local SDK version

Signed-off-by: dikel <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
…a script for running it with the local SDK version

Signed-off-by: dikel <[email protected]>
…a script for running it with the local SDK version

Signed-off-by: dikel <[email protected]>
…a script for running it with the local SDK version

Signed-off-by: dikel <[email protected]>
@ochikov ochikov force-pushed the improve-android-example branch from 708926f to fba9069 Compare October 26, 2022 07:33
@ochikov ochikov merged commit 1246837 into develop Oct 26, 2022
@ochikov ochikov deleted the improve-android-example branch October 26, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make android example easier to compile with current SDK version
3 participants