Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom derivation paths in Mnemonic ECDSA private key derivation #958

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

bguiz
Copy link
Member

@bguiz bguiz commented Jun 10, 2024

Description:

What

  • Add custom derivation path capability

Why

Related issue(s):

Fixes: hiero-ledger/hiero-sdk-java#1263 (comment)

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@bguiz bguiz requested review from a team as code owners June 10, 2024 14:40
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bguiz bguiz changed the title feat: custom derivation paths in Menmonic ECDSA private key derivation feat: custom derivation paths in Mnemonic ECDSA private key derivation Jun 12, 2024
@0xivanov
Copy link
Contributor

Overall Looks good, will take a closer look next week and will include this in the next release probably.

@bguiz
Copy link
Member Author

bguiz commented Jun 12, 2024

Overall Looks good, will take a closer look next week and will include this in the next release probably.

Thanks!

@SimiHunjan SimiHunjan added this to the v2.41.0 milestone Jun 24, 2024
@0xivanov 0xivanov merged commit ea3cb86 into hiero-ledger:main Jun 25, 2024
8 checks passed
@Petyo-Lukanov Petyo-Lukanov modified the milestones: v2.41.0, v2.40.0 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromMnemonic returns a private key which shouldn't be used
4 participants