Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Data type casting from onnx #87

Closed
soodoshll opened this issue Feb 12, 2023 · 2 comments · Fixed by #88
Closed

[Bug] Data type casting from onnx #87

soodoshll opened this issue Feb 12, 2023 · 2 comments · Fixed by #88

Comments

@soodoshll
Copy link
Collaborator

When importing an onnx model, hidet needs to map onnx data types into hidet dtypes.

However, in

hidet/python/hidet/graph/frontend/onnx/onnx.py

Line 485 in 0cd78c7

11: 'double',

hidet does not have dtype double. I guess it should be float64?
@yaoyaoding
Copy link
Member

Yes. Do you have an interest in submitting a PR to fix it (by replacing 'double' to 'float64')?

@soodoshll soodoshll mentioned this issue Feb 12, 2023
Merged
@soodoshll
Copy link
Collaborator Author

Yes. Do you have an interest in submitting a PR to fix it (by replacing 'double' to 'float64')?

Sure, it's here #88.

yaoyaoding pushed a commit that referenced this issue Apr 3, 2024
@KTong821
[Fixbug] Mark slow compiled app test (#89)
01b7b92 
Flagging slow tests as a result of huggingface dependency
(2hrs). To debug on private CI runs.

Resolves #87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix] 'double'->'float64' in onnx dtype conversion soodoshll/hidet
2 participants
@soodoshll @yaoyaoding