Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellarator non-symmetric configurations in vmec_splines #414

Merged
merged 2 commits into from
May 15, 2024

Conversation

daringli
Copy link
Contributor

Adds support for stellarator non-symmetric configurations in vmec_splines. A notable example of such a configuration is ITER, where the lower-null divertor breaks stellarator symmetry.
For stellarator symmetric configuration, the additional outputs are all zero.

@daringli
Copy link
Contributor Author

Your commit looks like a strict improvement. Thank you for making these changes.
The X, Y, Z, etc. outputs from vmec_compute_geometry had snuck in from a previous edit that had nothing to do with this. Thanks for removing them.

@landreman landreman self-requested a review May 15, 2024 15:10
@landreman landreman merged commit 3163266 into hiddenSymmetries:master May 15, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants