fix for failing workflows on github actions #406
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with github actions that I've noticed:
The first problem is documented in issue #357. The unit tests now pass if I remove the
with ScratchDir:
fromsimsopt/tests/mhd/test_spec.py
Line 141 in 38a20cb
The second problem is documented in issue #405. For some reason, mayavi is having issues installing on some of the runners:
https://github.com/hiddenSymmetries/simsopt/actions/runs/8741345143/job/23987152753?pr=404
https://github.com/hiddenSymmetries/simsopt/actions/runs/8754269959/job/24025642995?pr=404
The error goes away by removing VIS from
simsopt/.github/workflows/tests.yml
Line 166 in 38a20cb
since mayavi won't be installed.
Let's use this PR to discuss possible solutions, because the failing workflows are quite annoying. Removing
VIS
from above is not advisable, so we need to find an alternative way to fix the issue.