Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for failing workflows on github actions #406

Closed
wants to merge 1 commit into from

Conversation

andrewgiuliani
Copy link
Contributor

@andrewgiuliani andrewgiuliani commented Apr 19, 2024

This PR fixes two issues with github actions that I've noticed:

The first problem is documented in issue #357. The unit tests now pass if I remove the with ScratchDir: from

with ScratchDir("."):

The second problem is documented in issue #405. For some reason, mayavi is having issues installing on some of the runners:
https://github.com/hiddenSymmetries/simsopt/actions/runs/8741345143/job/23987152753?pr=404
https://github.com/hiddenSymmetries/simsopt/actions/runs/8754269959/job/24025642995?pr=404

The error goes away by removing VIS from

run: pip install -v ".[MPI,SPEC,VIS]"

since mayavi won't be installed.

Let's use this PR to discuss possible solutions, because the failing workflows are quite annoying. Removing VIS from above is not advisable, so we need to find an alternative way to fix the issue.

@andrewgiuliani andrewgiuliani changed the title fix for unit tests fix for failing workflows on github actions Apr 19, 2024
@andrewgiuliani andrewgiuliani deleted the ag/unit_test_fixes branch April 20, 2024 00:34
@andrewgiuliani andrewgiuliani restored the ag/unit_test_fixes branch April 20, 2024 00:34
@andrewgiuliani andrewgiuliani deleted the ag/unit_test_fixes branch April 20, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant