New magnetic field class - mirror machine #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. However, for some reason, I don't obtain a symmetric grad B tensor. Still checking out why. |
|
Actually the field is not curl-free so the gradB tensor is expected to not be symmetric |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 91.35% 91.04% -0.32%
==========================================
Files 68 68
Lines 12042 12110 +68
==========================================
+ Hits 11001 11025 +24
- Misses 1041 1085 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
landreman
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the mirror machine model from https://arxiv.org/abs/2305.06372
It expands the set of magnetic field models available to SIMSOPT to include a magnetic mirror model for fusion applications. The default input parameters follow the ones used to model WHAM (https://wippl.wisc.edu/wisconsin-hts-axisymmetric-mirror/)