PR: Added a surface.from_pyQSC method and tests #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 91.93% 91.51% -0.43%
==========================================
Files 62 62
Lines 10099 10118 +19
==========================================
- Hits 9285 9259 -26
- Misses 814 859 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
landreman
reviewed
Apr 23, 2023
| Args: | ||
| stel: Qsc object with a near-axis equilibrium. | ||
| r: the near-axis coordinate radius (in meters). | ||
| kwargs: Any other arguments to pass to the ``SurfaceRZFourier`` constructor. |
There was a problem hiding this comment.
Document ntheta, mpol, and ntor in docstring.
There was a problem hiding this comment.
Fixed in commit fe9697e
landreman
approved these changes
Apr 23, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to generate a SurfaceRZFourier directly from a pyQSC instance (a Qsc class).
It helps users perform stage 1 and stage 2 optimizations involving near-axis expansions, either as initial conditions or not.