-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes in some tests #293
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 91.67% 91.36% -0.31%
==========================================
Files 61 61
Lines 9706 9706
==========================================
- Hits 8898 8868 -30
- Misses 808 838 +30
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Should we add |
Yes.
…On Thu, Mar 2, 2023, 2:45 PM Matt Landreman ***@***.***> wrote:
Should we add @unittest.skipIf(virtual_casing is None) at test_virtual_casing
line 56
<https://github.com/hiddenSymmetries/simsopt/blob/master/tests/mhd/test_virtual_casing.py#L56>
too? I believe the tests in that file are divided in 2 classes because only
test_different_initializations() needs to actually have vmec installed,
but all the tests in the test_virtual_casing file need to have the
virtual_casing module installed.
—
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA62VEHLYQAMUSIMMDYGX2LW2D2GPANCNFSM6AAAAAAVNNGRYY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Updated mhd/test_virtual_casing.py to correctly capture the skip conditions. |
This PR adds some minor fixes to tests to make them optional and definitive.