Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in some tests #293

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Minor fixes in some tests #293

merged 4 commits into from
Mar 13, 2023

Conversation

mbkumar
Copy link
Collaborator

@mbkumar mbkumar commented Mar 2, 2023

This PR adds some minor fixes to tests to make them optional and definitive.

@mbkumar mbkumar requested a review from landreman March 2, 2023 13:56
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.31 ⚠️

Comparison is base (795ff6e) 91.67% compared to head (82c7b1d) 91.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   91.67%   91.36%   -0.31%     
==========================================
  Files          61       61              
  Lines        9706     9706              
==========================================
- Hits         8898     8868      -30     
- Misses        808      838      +30     
Flag Coverage Δ
unittests 91.36% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@landreman
Copy link
Contributor

Should we add @unittest.skipIf(virtual_casing is None) at test_virtual_casing line 56 too? I believe the tests in that file are divided in 2 classes because only test_different_initializations() needs to actually have vmec installed, but all the tests in the test_virtual_casing file need to have the virtual_casing module installed.

@mbkumar
Copy link
Collaborator Author

mbkumar commented Mar 2, 2023 via email

@mbkumar mbkumar mentioned this pull request Mar 10, 2023
@mbkumar
Copy link
Collaborator Author

mbkumar commented Mar 10, 2023

Updated mhd/test_virtual_casing.py to correctly capture the skip conditions.

@landreman landreman merged commit 247ea2a into master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants