Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few minor changes:
(1) the implementation of
to_RZFourier
in the SurfaceXYZTensorFourier class is incorrect and untested. That's how this was missed. It seems like the previous version was using an old interface to theSurfaceRZFourier
constructor.(2) A unit test that computes BoozerSurfaces in some of the included configurations was only running on the JPP (get_giuliani_data) data set, whereas previously it would also run on the NCSX and HSX datasets. I have added those back in to the unit test.
(3) additional unittests for SurfaceXYZTensorFourier. I have added these to the
test_surfacexyzfourier.py
file.-Andrew