Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ag/minor bug fixes and changes #291

Merged
merged 4 commits into from
Feb 24, 2023
Merged

ag/minor bug fixes and changes #291

merged 4 commits into from
Feb 24, 2023

Conversation

andrewgiuliani
Copy link
Contributor

@andrewgiuliani andrewgiuliani commented Feb 23, 2023

This PR introduces a few minor changes:

(1) the implementation of to_RZFourier in the SurfaceXYZTensorFourier class is incorrect and untested. That's how this was missed. It seems like the previous version was using an old interface to the SurfaceRZFourier constructor.
(2) A unit test that computes BoozerSurfaces in some of the included configurations was only running on the JPP (get_giuliani_data) data set, whereas previously it would also run on the NCSX and HSX datasets. I have added those back in to the unit test.
(3) additional unittests for SurfaceXYZTensorFourier. I have added these to the test_surfacexyzfourier.py file.

-Andrew

@andrewgiuliani andrewgiuliani changed the title Ag/minor fixes ag/minor bug fixes Feb 23, 2023
@andrewgiuliani andrewgiuliani changed the title ag/minor bug fixes ag/minor bug fixes and changes Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 91.61% // Head: 91.67% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (0cf42b9) compared to base (908991b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   91.61%   91.67%   +0.06%     
==========================================
  Files          61       61              
  Lines        9704     9706       +2     
==========================================
+ Hits         8890     8898       +8     
+ Misses        814      808       -6     
Flag Coverage Δ
unittests 91.67% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/simsopt/geo/surfacexyztensorfourier.py 94.44% <100.00%> (+11.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewgiuliani andrewgiuliani marked this pull request as ready for review February 23, 2023 18:54
@andrewgiuliani andrewgiuliani merged commit 795ff6e into master Feb 24, 2023
@andrewgiuliani andrewgiuliani deleted the ag/minor_fixes branch February 24, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants