Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for padding in RegularGridInterpolant3D #290

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

mbkumar
Copy link
Collaborator

@mbkumar mbkumar commented Feb 23, 2023

There is a bug in simd padding in RegularGridInterpolant3D. When the size is the multiple of simdcount, spurious padding bytes are added.

@mbkumar mbkumar requested a review from landreman February 23, 2023 14:44
@mbkumar
Copy link
Collaborator Author

mbkumar commented Feb 23, 2023

Minor bug fix in padding for simd code

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 91.61% // Head: 91.61% // No change to project coverage 👍

Coverage data is based on head (2aa0b3a) compared to base (908991b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          61       61           
  Lines        9704     9704           
=======================================
  Hits         8890     8890           
  Misses        814      814           
Flag Coverage Δ
unittests 91.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@landreman landreman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@landreman landreman merged commit 3114571 into master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants