ScreenShot ( overlayApi.takeScreenShot ) feature and UXUI Update #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 CODE LogParseOverlay why fired event 'onOverlayDataUpdate' include 'CombatantData'? |
* No Changes
* Change font to Microsoft NeoGothic
* Remove Data refresh interval?
* Forced replace
Merge Works
* ScreenShot to Screenshot
* Modify Margin, Padding
* size unification
* Button Size, Style
* Removed Unused value, using header * Release version fix
* missed
|
Logparse was intended to addition of MiniParse, so it can be edited to borrow miniparse-related code from miniparse classes. |
|
Ok understand, just curious. |
quisquous
added a commit
to quisquous/OverlayPlugin
that referenced
this pull request
Oct 8, 2022
Previously, OverlayPlugin supported two plugin ids, 77 for normal releases and 86 for preleases, accessible by double clicking on the update button. This logic should probably be cleaned up and removed but this is a minimal patch to allow for a broader OverlayPlugin release with minimal risk. EQAditu suggested after some testing that the new OverlayPlugin should use a different id to avoid some error cases. If OverlayPlugin wants to handle prereleases in the future, we can add this back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.