Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-1775 Rename CDI extension service file for new jakarta package #1095

Merged
merged 1 commit into from
May 13, 2020

Conversation

jGauravGupta
Copy link
Contributor

Signed-off-by: Gaurav Gupta [email protected]

@Hibernate-CI
Copy link
Contributor

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

@gsmet gsmet changed the title Fix services provider configuration file HV-1775 Rename CDI extension service file for new jakarta package May 13, 2020
@gsmet
Copy link
Member

gsmet commented May 13, 2020

ok to test

@gsmet
Copy link
Member

gsmet commented May 13, 2020

@jGauravGupta thanks! Unfortunately, I wasn't able to test the CDI extension back in the time because I had no CDI implementation available.

I amended your commit to include a JIRA issue number.

Do you have more fixes coming or should I release an Alpha2?

@gsmet gsmet merged commit 1a15567 into hibernate:master May 13, 2020
@gsmet
Copy link
Member

gsmet commented May 13, 2020

OK, I was able to restore the CDI extension tests as Weld has made progress on their side.

Following your PR, all the tests pass so I'm releasing 7.0.0.Alpha2. It should sync to Central sometime tomorrow.

@gsmet
Copy link
Member

gsmet commented May 14, 2020

@jGauravGupta Alpha2 is now available on Central.

@jGauravGupta
Copy link
Contributor Author

Thanks @gsmet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants