HSEARCH-4403 Support ORM's discriminator-based multi-tenancy in the outbox-polling module

[marko-bekhta]

https://hibernate.atlassian.net/browse/HSEARCH-4403

Opening as a draft as this won't work for now while the changes are not applied to ORM

[yrodiere]

Some early comments while we're waiting for the necessary changes to be merged in Hibernate ORM :)

And BTW, you might want to ping someone so that it's merged before 6.3.0.Final gets released...

[marko-bekhta]

waiting for the fix from hibernate/hibernate-orm#7171

[yrodiere]

Looks like it's failing:

[ERROR] --[ Constraint Violation ]-----------------------------------------

[ERROR] Constraint: hsearch:TypesMayNotDependOnImplementationTypeFromOtherModules

[ERROR] Severity: MAJOR

[ERROR] Number of rows: 2

[ERROR]             Main (non-test) types must not depend on implementation types from other modules.

[ERROR]             SPIs must be used for such dependencies.

[ERROR]             Exceptions are allowed only when the dependency type is in a util module,

[ERROR]             or the depending type is a test type.

[ERROR]         

[ERROR]   artifact1=org.hibernate.search:hibernate-search-mapper-orm-coordination-outbox-polling:jar:7.0.0-SNAPSHOT, type1=org.hibernate.search.mapper.orm.coordination.outboxpolling.cluster.impl.OutboxPollingAgentAdditionalJaxbMappingProducer, artifact2=org.hibernate.search:hibernate-search-mapper-orm:jar:7.0.0-SNAPSHOT, type2=org.hibernate.search.mapper.orm.common.impl.HibernateOrmUtils

[ERROR]   artifact1=org.hibernate.search:hibernate-search-mapper-orm-coordination-outbox-polling:jar:7.0.0-SNAPSHOT, type1=org.hibernate.search.mapper.orm.coordination.outboxpolling.event.impl.OutboxPollingOutboxEventAdditionalJaxbMappingProducer, artifact2=org.hibernate.search:hibernate-search-mapper-orm:jar:7.0.0-SNAPSHOT, type2=org.hibernate.search.mapper.orm.common.impl.HibernateOrmUtils

I guess you can have separate utils directly in the outbox-polling module if necessary

[marko-bekhta]

will need ORM 6.3.1 for this one 🙈

[yrodiere]

will need ORM 6.3.1 for this one 🙈

That's... annoying. We may have to postpone to Search 7.1 then. We'll see.

[marko-bekhta]

I've added a patch to ORM; the info on the preferred id JDBC type wasn't passed further from the XML....
But there's also a difference in behaviour with long32varbinary.. maybe let's talk about that today

[yrodiere]

Thanks. A few comments on the latest version :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

86.9% Coverage
0.0% Duplication