Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[910] SchemaMigrator/SchemaValidator support for MySQL and MariaDB #940

Closed
wants to merge 12 commits into from
Closed

[910] SchemaMigrator/SchemaValidator support for MySQL and MariaDB #940

wants to merge 12 commits into from

Conversation

gbadner
Copy link
Contributor

@gbadner gbadner commented Aug 16, 2021

gbadner added 11 commits July 23, 2021 17:13
@gbadner
[536] SchemaMigrator support for PostgreSQL
acb6c04
@gbadner
[536] Correct order of arguments to TestContext#assertEquals
99eb01a
@gbadner
[536] : Change SQL keywords to lowercase
ba2e5f9
@gbadner
[536] Encapsulate extraction methods into ReactiveExtractionTool
7552fa8 
[536] : Added Javodoc, made minor changes to sych up with ORM, changed more SQL keywords that were upper-case to lower-case
@gbadner
[536] : Use org.hibernate.reactive.pool.impl.Parameters#process for d…
cd964b9 
…ialect-specific parameter placeholders
@gbadner
[536] : Add a method for non-standard information_schema.columns colu…
82fb199 
…mn name used by PostgreSQL
@gbadner
[536] Change ResultSetAdapter#getLong(String) to be convert String …
63041ad 
…to Long
@gbadner
[536] Change ResultSetAdapter#getLong(String) to throw the original…
a4ec4b3 
… exception if the value is neither a long nor a String that can be parsed as a long.
@gbadner
[910] SchemaMigrator/SchemaValidator support for MySQL
87a77bc
@gbadner
[910] Fix off-by-one bug in ResultSetAdaptor#getXXX(int columnIndex) …
252e482 
…methods
@gbadner
[910] SchemaMigrator/SchemaValidator support for MariaDB
11214b9
@gbadner gbadner changed the title [910] SchemaMigrator/SchemaValidator support for MySQL [910] SchemaMigrator/SchemaValidator support for MySQL and MariaDB Aug 19, 2021
@gbadner
Copy link
Contributor Author

gbadner commented Aug 19, 2021

I've added 2 commits:

252e482 fixes an off-by-one bug in `ResultSetAdapter#getXXX(int columnIndex). @gavinking, you should probably look at this one.

11214b9 adds support for MariaDB. It just uses the same code as MySQL.

@gbadner
Copy link
Contributor Author

gbadner commented Aug 19, 2021

I forgot to say "thank you" to @blafond for helping to get things started with supporting MariaDB.

Thanks @blafond!

@gavinking
Copy link
Member

@gbadner OK I guess we were never using lookup by column index before so I suppose that's correct.

@gbadner
Copy link
Contributor Author

gbadner commented Aug 24, 2021

Pushed a commit to improve Javadoc and simplify MySqlReactiveInformationExtractorImpl methods

@gbadner gbadner marked this pull request as ready for review August 24, 2021 02:27
@gavinking
Copy link
Member

@gbadner could you please rebase this on the latest main branch, which now depends on the latest ORM (which includes your work over there).

@gbadner gbadner mentioned this pull request Aug 30, 2021
Merged
@gbadner
Copy link
Contributor Author

gbadner commented Aug 30, 2021

I've merged the commits from this PR into #903, so closing this PR.

@gbadner gbadner closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbadner @gavinking