HHH-13677 Make org.hibernate.flushMode config take effect #3144
Conversation
NathanQingyangXu
changed the title
NathanQingyangXu
force-pushed
the
HHH-13677
branch
5 times, most recently
from
cf49cb0 to
8affd32
Compare
NathanQingyangXu
force-pushed
the
HHH-13677
branch
from
8affd32 to
0be6442
Compare
|
Thank you, guys! |
| @@ -256,6 +256,8 @@ public SessionImpl(SessionFactoryImpl factory, SessionCreationOptions options) { | |||
| // NOTE : pulse() already handles auto-join-ability correctly | |||
| getTransactionCoordinator().pulse(); | |||
|
|
|||
| getSession().setHibernateFlushMode( ConfigurationHelper.getFlushMode( getSessionProperty( AvailableSettings.FLUSH_MODE ), FlushMode.AUTO ) ); | |||
|
|
|||
There was a problem hiding this comment.
@Sanne should we add the FlushMode to the FastSessionServices?
There was a problem hiding this comment.
Actually, FastSessionServices contains FlushMode default value. If you drill down the getSessionProperty() you can see it will look up in FastSessionServices by default. The FlushMode.AUTO above will never take effect for FastSessionServices should have returned a non-null value for AvailableSettings.FLUSH_MODE :
There was a problem hiding this comment.
Right, looks good. Is something not working as expected @dreab8 ? Feel free to add tests :)
There was a problem hiding this comment.
I haven't noticed that getSessionProperty takes the value from the FastSessionServices
There was a problem hiding this comment.
hum both ConfigurationHelper#getFlushMode and the getSessionProperty methods are rather slow though. I see what @dreab8 meant now, I will add an additional fix to this.
|
Applied upstream. |
https://hibernate.atlassian.net/browse/HHH-13677
We ignored setting flush mode during session building. This PR simply grabs the setting from
fastSessionService. Testing case added.