HHH-10668 - Add SQL dialect for SQLite 3

.gitignore

@@ -47,3 +47,4 @@ ObjectStore
 # Additional databases used in local envs
 databases/mysql/
 databases/postgis/
+

build.gradle

@@ -168,6 +168,7 @@ subprojects { subProject ->
 		testRuntime( libraries.mariadb )
 		testRuntime( libraries.mssql )
 		testRuntime( libraries.informix )
+		testRuntime( libraries.sqlite )
 
 		if (db.equalsIgnoreCase("oracle")) {
 			dependencies {

databases.gradle

@@ -78,6 +78,13 @@ ext {
                         'jdbc.user'  : 'informix',
                         'jdbc.pass'  : 'in4mix',
                         'jdbc.url'   : 'jdbc:informix-sqli://192.168.99.100:9088/sysuser:INFORMIXSERVER=dev;user=informix;password=in4mix'
+                ],
+                sqlite : [
+                        'db.dialect' : 'org.hibernate.dialect.SQLiteDialect',
+                        'jdbc.driver': 'org.sqlite.JDBC',
+                        'jdbc.user'  : 'hibernate_orm_test',
+                        'jdbc.pass'  : 'hibernate_orm_test',
+                        'jdbc.url'   : 'jdbc:sqlite:target/sqlite_test.db'
                 ]
         ]
 }

documentation/documentation.gradle

@@ -70,6 +70,7 @@ dependencies {
 	testRuntime( libraries.mysql )
 	testRuntime( libraries.mariadb )
 	testRuntime( libraries.mssql )
+	testRuntime( libraries.sqlite )
 
 	if (db.equalsIgnoreCase("oracle")) {
 		dependencies {

documentation/src/test/java/org/hibernate/userguide/flush/AutoFlushTest.java

@@ -16,6 +16,9 @@
 import org.hibernate.Session;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
+import org.hibernate.testing.DialectCheck;
+import org.hibernate.testing.DialectChecks;
+import org.hibernate.testing.RequiresDialectFeature;
 import org.junit.Test;
 
 import org.jboss.logging.Logger;
@@ -112,6 +115,7 @@ public void testFlushAutoSQL() {
 	}
 
 	@Test
+	@RequiresDialectFeature(DialectChecks.DoesNotPrefersIdentityOverSequence.class)
 	public void testFlushAutoSQLNativeSession() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			entityManager.createNativeQuery( "delete from Person" ).executeUpdate();;

documentation/src/test/java/org/hibernate/userguide/flush/ManualFlushTest.java

@@ -20,6 +20,8 @@
 import org.hibernate.Session;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
+import org.hibernate.testing.DialectChecks;
+import org.hibernate.testing.RequiresDialectFeature;
 import org.junit.Test;
 
 import org.jboss.logging.Logger;
@@ -44,6 +46,7 @@ protected Class<?>[] getAnnotatedClasses() {
     }
 
     @Test
+    @RequiresDialectFeature(DialectChecks.DoesNotPrefersIdentityOverSequence.class)
     public void testFlushSQL() {
         doInJPA( this::entityManagerFactory, entityManager -> {
             entityManager.createNativeQuery("delete from Person").executeUpdate();

documentation/src/test/java/org/hibernate/userguide/hql/HQLTest.java

@@ -30,6 +30,7 @@
 import org.hibernate.dialect.Oracle8iDialect;
 import org.hibernate.dialect.PostgreSQL81Dialect;
 import org.hibernate.dialect.SQLServerDialect;
+import org.hibernate.dialect.SQLiteDialect;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 import org.hibernate.type.StringType;
 import org.hibernate.userguide.model.AddressType;
@@ -861,6 +862,7 @@ public void test_hql_api_scroll_projection_example() {
 	}
 
 	@Test
+	@SkipForDialect(SQLiteDialect.class)
 	public void test_hql_api_scroll_open_example() {
 		ScrollableResults scrollableResults = doInJPA( this::entityManagerFactory, entityManager -> {
 			Session session = entityManager.unwrap( Session.class );
@@ -1037,6 +1039,7 @@ public void test_hql_numeric_arithmetic_example_1() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "EXTRACT function is not supported")
 	public void test_hql_numeric_arithmetic_example_2() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			//tag::hql-numeric-arithmetic-example[]
@@ -1053,6 +1056,7 @@ public void test_hql_numeric_arithmetic_example_2() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "EXTRACT function is not supported")
 	public void test_hql_numeric_arithmetic_example_3() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			//tag::hql-numeric-arithmetic-example[]
@@ -1348,6 +1352,7 @@ public void test_hql_cast_function_example() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "EXTRACT function is not supported")
 	public void test_hql_extract_function_example() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			//tag::hql-extract-function-example[]
@@ -1361,6 +1366,7 @@ public void test_hql_extract_function_example() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "EXTRACT function is not supported")
 	public void test_hql_year_function_example() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			//tag::hql-year-function-example[]
@@ -1469,6 +1475,7 @@ public void test_hql_collection_expressions_example_4() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "SOME operator is not supported")
 	public void test_hql_collection_expressions_example_5() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			Call call = entityManager.createQuery( "select c from Call c", Call.class).getResultList().get( 0 );
@@ -1517,6 +1524,7 @@ public void test_hql_collection_expressions_example_7() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "ALL operator is not supported")
 	public void test_hql_collection_expressions_example_8() {
 		doInJPA( this::entityManagerFactory, entityManager -> {
 			//tag::hql-collection-expressions-example[]
@@ -1934,6 +1942,7 @@ public void test_hql_relational_comparisons_example_7() {
 	}
 
 	@Test
+	@SkipForDialect(value = SQLiteDialect.class, comment = "ALL operator is not supported")
 	public void test_hql_all_subquery_comparison_qualifier_example() {
 
 		doInJPA( this::entityManagerFactory, entityManager -> {

documentation/src/test/java/org/hibernate/userguide/mapping/basic/NClobCharArrayTest.java

@@ -13,6 +13,7 @@
 import org.hibernate.annotations.Nationalized;
 import org.hibernate.dialect.MySQL5Dialect;
 import org.hibernate.dialect.PostgreSQL81Dialect;
+import org.hibernate.dialect.SQLiteDialect;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
 import org.hibernate.testing.SkipForDialect;
@@ -27,7 +28,8 @@
 @SkipForDialect(
 		value = {
 				PostgreSQL81Dialect.class,
-				MySQL5Dialect.class
+				MySQL5Dialect.class,
+				SQLiteDialect.class
 		},
 		comment = "@see https://hibernate.atlassian.net/browse/HHH-10693 and https://hibernate.atlassian.net/browse/HHH-10695"
 )

documentation/src/test/java/org/hibernate/userguide/mapping/basic/NClobStringTest.java

@@ -13,6 +13,7 @@
 import org.hibernate.annotations.Nationalized;
 import org.hibernate.dialect.MySQL5Dialect;
 import org.hibernate.dialect.PostgreSQL81Dialect;
+import org.hibernate.dialect.SQLiteDialect;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
 import org.hibernate.testing.SkipForDialect;
@@ -27,7 +28,8 @@
 @SkipForDialect(
 		value = {
 				PostgreSQL81Dialect.class,
-				MySQL5Dialect.class
+				MySQL5Dialect.class,
+				SQLiteDialect.class
 		},
 		comment = "@see https://hibernate.atlassian.net/browse/HHH-10693 and https://hibernate.atlassian.net/browse/HHH-10695"
 )

documentation/src/test/java/org/hibernate/userguide/mapping/basic/NClobTest.java

@@ -19,6 +19,7 @@
 import org.hibernate.annotations.Nationalized;
 import org.hibernate.dialect.MySQL5Dialect;
 import org.hibernate.dialect.PostgreSQL81Dialect;
+import org.hibernate.dialect.SQLiteDialect;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
 import org.hibernate.testing.SkipForDialect;
@@ -34,7 +35,8 @@
 @SkipForDialect(
 		value = {
 				PostgreSQL81Dialect.class,
-				MySQL5Dialect.class
+				MySQL5Dialect.class,
+				SQLiteDialect.class
 		},
 		comment = "@see https://hibernate.atlassian.net/browse/HHH-10693 and https://hibernate.atlassian.net/browse/HHH-10695"
 )

documentation/src/test/java/org/hibernate/userguide/mapping/basic/NationalizedTest.java

@@ -11,6 +11,7 @@
 
 import org.hibernate.annotations.Nationalized;
 import org.hibernate.dialect.PostgreSQL81Dialect;
+import org.hibernate.dialect.SQLiteDialect;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
 import org.hibernate.testing.SkipForDialect;
@@ -24,7 +25,8 @@
  */
 @SkipForDialect(
 		value = {
-				PostgreSQL81Dialect.class
+			PostgreSQL81Dialect.class,
+			SQLiteDialect.class
 		},
 		comment = "@see https://hibernate.atlassian.net/browse/HHH-10693"
 )

documentation/src/test/java/org/hibernate/userguide/mapping/identifier/PooledOptimizerTest.java

@@ -16,13 +16,16 @@
 import org.hibernate.annotations.Parameter;
 import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
 
+import org.hibernate.testing.DialectChecks;
+import org.hibernate.testing.RequiresDialectFeature;
 import org.junit.Test;
 
 import static org.hibernate.testing.transaction.TransactionUtil.doInJPA;
 
 /**
  * @author Vlad Mihalcea
  */
+@RequiresDialectFeature( { DialectChecks.SupportsSequences.class, DialectChecks.DoesNotPrefersIdentityOverSequence.class } )
 public class PooledOptimizerTest extends BaseEntityManagerFunctionalTestCase {
 
 	@Override

hibernate-core/src/main/java/org/hibernate/boot/internal/IdGeneratorInterpreterImpl.java

@@ -222,7 +222,7 @@ public String determineGeneratorName(GenerationType generationType, GeneratorNam
 						return UUIDGenerator.class.getName();
 					}
 					else {
-						return org.hibernate.id.enhanced.SequenceStyleGenerator.class.getName();
+						return "auto";
 					}
 				}
 			}

hibernate-core/src/main/java/org/hibernate/boot/registry/selector/internal/StrategySelectorBuilder.java

@@ -58,6 +58,7 @@
 import org.hibernate.dialect.PostgresPlusDialect;
 import org.hibernate.dialect.ProgressDialect;
 import org.hibernate.dialect.SAPDBDialect;
+import org.hibernate.dialect.SQLiteDialect;
 import org.hibernate.dialect.SQLServer2005Dialect;
 import org.hibernate.dialect.SQLServer2008Dialect;
 import org.hibernate.dialect.SQLServerDialect;
@@ -224,6 +225,7 @@ private void addDialects(StrategySelectorImpl strategySelector) {
 		addDialect( strategySelector, PostgreSQL9Dialect.class );
 		addDialect( strategySelector, ProgressDialect.class );
 		addDialect( strategySelector, SAPDBDialect.class );
+		addDialect( strategySelector, SQLiteDialect.class );
 		addDialect( strategySelector, SQLServerDialect.class );
 		addDialect( strategySelector, SQLServer2005Dialect.class );
 		addDialect( strategySelector, SQLServer2008Dialect.class );

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -796,6 +796,15 @@ public boolean supportsSequences() {
 		return false;
 	}
 
+	/**
+	 * By default, SEQUENCE is preferred over IDENTITY.
+	 *
+	 * @return is IDENTITY preferred
+	 */
+	public boolean prefersIdentityOverSequence() {
+		return false;
+	}
+
 	/**
 	 * Does this dialect support "pooled" sequences.  Not aware of a better
 	 * name for this.  Essentially can we specify the initial and increment values?

hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQL81Dialect.java

@@ -188,7 +188,7 @@ public SqlTypeDescriptor getSqlTypeDescriptorOverride(int sqlCode) {
 				break;
 			}
 			case Types.CLOB: {
-				descriptor = ClobTypeDescriptor.POSTGRESQL_CLOB_BINDING;
+				descriptor = ClobTypeDescriptor.STRING_CLOB_BINDING;
 				break;
 			}
 			default: {