SQLite dialect

[luca-vercelli]

As discussed here, I have updated gradle configuration for including SQLite dialect.
Out of 369 tests, 28 fails and 42 are ignored, with a 91% of success. I guess tests fail due to JDBC limitations. Here is the list of failing tests:

BatchTest. testScroll
BatchTest. testStatelessSession
AutoFlushTest. testFlushAutoSQL
AutoFlushTest. testFlushAutoSQLNativeSession
AutoFlushTest. testFlushAutoSQLSynchronization
HQLTest. test_hql_all_subquery_comparison_qualifier_example
HQLTest. test_hql_api_scroll_open_example
HQLTest. test_hql_collection_expressions_example_5
HQLTest. test_hql_collection_expressions_example_7
HQLTest. test_hql_collection_expressions_example_8
HQLTest. test_hql_extract_function_example
HQLTest. test_hql_in_predicate_example_6
HQLTest. test_hql_locate_function_example
HQLTest. test_hql_numeric_arithmetic_example_2
HQLTest. test_hql_numeric_arithmetic_example_3
HQLTest. test_hql_substring_function_example
HQLTest. test_hql_year_function_example
BlobByteArrayTest. test
BlobTest. test
ClobCharArrayTest. test
ClobStringTest. test
ClobTest. test
NClobCharArrayTest. test
NClobStringTest. test
NClobTest. test
NationalizedTest. test
DatabaseValueGenerationTest. test
PooledOptimizerTest. test

[vladmihalcea]

Thanks @luca-vercelli. I'll review on Monday.

[vladmihalcea]

@luca-vercelli Did you sign the CLA?

[vladmihalcea]

You have a merge commit which prevents me from rebasing your work on top of master. Try squashing all your changes and submit it as one commit so that I can integrate it. We never issue any merge between branches. We always rebase.

[vladmihalcea]

Is this imported from NHibernate? Can we check it how it works there too?

[vladmihalcea]

How should this be fixed in future. Is this also something related to NHibernate?

[vladmihalcea]

Why not providing it by default? The Oracle is a special case because it's not available on Maven Central.

[vladmihalcea]

@luca-vercelli I see you committed on master on your fork. This is not usually a good thing to do since it restricts you to fetching the latest changes from upstream.

What you can do to easily fix the merge commit problem is to follow these steps:

1. Create a new branch called sqlite
2. git checkout sqlite
3. git merge --squash master

Then you should have all changes in the sqlite branch which you can use to send the PR.

The master branch should be reset so that all extra commits you've done are removed. Then you can merge from upstream/master, assuming you added the upstream mirror, and then you can also rebase the sqlite branch.

[luca-vercelli]

@vladmihalcea, yes, I just begun to work on this. I will create a new branch ASAP.

[vladmihalcea]

@luca-vercelli Thanks

[luca-vercelli]

Dear @vladmihalcea your suggestion does not work. I did:

$git branch sqlite
$git checkout sqlite
$git merge --squash master
 (nothing to squash)Already up-to-date.

[luca-vercelli]

Maybe I could just drop completely my repository, then create a new one again and put all gwenn's modified files as they were mine... I don't like that so much...

[vladmihalcea]

You can also use git cherry-pick each commit that you did on master onto the new branch. Make sure that you skip the merge commits.

[luca-vercelli]

You should find a new branch sqlite. I have git cherry-picked all commits but merge commits into that branch.

[vladmihalcea]

Thanks. I'll check it out on Monday.

[vladmihalcea]

Replaced by this PR.