-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vite-node-miniflare): use ssr.optimizeDeps
for vite-node
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Jan 9, 2024
hi-ogawa
changed the title
fix(vite-node-miniflare): use
refactor(vite-node-miniflare): use Jan 9, 2024
ssr.optimizeDeps
for vite-nodessr.optimizeDeps
for vite-node
Looks like
This decision is coming from here:
|
…into fix-vite-node-ssr-optimizeDeps
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssr.optimizeDeps
forvite-node-miniflare
#151(To be merged after Vite 5.1 release with vitejs/vite#15561)
summary
ssrLoadModule
to trigger ssr deps optimizationssr.target: "webworker"
so that esbuild pre-bundling target is"browser"
ViteNodeServerOptions.cacheDir
to random directory to disable vite-node's externalizationold comment
Vite/esbuild doesn't look happy with bundling
react-dom/server
:Probably tweaking
ssr.optimizeDeps.esbuildOptions
would make it work?(Either force
resolve.conditions
tobrowser
or just importingreact-dom/server.browser
is fine)