feat: optional ssr hmr (disabled by default)

hi-ogawa · Jan 31, 2024 · 95d6705 · 95d6705
1 parent 9b40a28
commit 95d6705
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/vite-node-miniflare/examples/react/vite.config.ts b/packages/vite-node-miniflare/examples/react/vite.config.ts
@@ -18,6 +18,8 @@ export default defineConfig({
   },
   plugins: [
     vitePluginViteNodeMiniflare({
+      // TODO: ssr hmr plugin https://github.com/hi-ogawa/vite-plugins/pull/157
+      // hmr: true,
       debug: true,
       entry: "./src/worker-entry.tsx",
       miniflareOptions(options) {

diff --git a/packages/vite-node-miniflare/src/client/worker-entry.ts b/packages/vite-node-miniflare/src/client/worker-entry.ts
@@ -9,6 +9,7 @@ interface Env {
   __VITE_NODE_SERVER_RPC_URL: string;
   __VITE_NODE_RUNNER_OPTIONS: any;
   __VITE_NODE_DEBUG: boolean;
+  __VITE_RUNTIME_HMR: boolean;
   __WORKER_ENTRY: string;
 }
 
@@ -31,9 +32,8 @@ export default {
         const payloads = await client.rpc.getHMRPayloads();
         for (const payload of payloads) {
           console.log("[handleHMRUpdate]", payload);
-          // TODO: for now, we do module tree invalidation instead of hmr so that standard react plugin integration works like before.
-          // TODO: make it configurable
-          if (payload.type === "update") {
+          // simple module tree invalidation instead of hmr for client-only hmr plugin compatibility
+          if (!env.__VITE_RUNTIME_HMR && payload.type === "update") {
             for (const update of payload.updates) {
               // TODO: unwrapId?
               const invalidated = client.runtime.moduleCache.invalidateDepTree([

diff --git a/packages/vite-node-miniflare/src/server/plugin.ts b/packages/vite-node-miniflare/src/server/plugin.ts
@@ -14,6 +14,8 @@ import { setupViteNodeServerRpc } from "./vite-node";
 export function vitePluginViteNodeMiniflare(pluginOptions: {
   entry: string;
   debug?: boolean;
+  // ssr hmr is disabled by default for normal client-only hmr plugin compatibility
+  hmr?: boolean;
   // hooks to customize options
   miniflareOptions?: (options: MiniflareOptions) => void;
   viteNodeServerOptions?: (options: ViteNodeServerOptions) => void;
@@ -82,6 +84,7 @@ export function vitePluginViteNodeMiniflare(pluginOptions: {
             entry: pluginOptions.entry,
             rpcOrigin: ctx.url.origin,
             debug: pluginOptions.debug,
+            hmr: pluginOptions.hmr,
             viteNodeRunnerOptions,
           });
           pluginOptions.miniflareOptions?.(miniflareOptions);

diff --git a/packages/vite-node-miniflare/src/server/vite-node.ts b/packages/vite-node-miniflare/src/server/vite-node.ts
@@ -90,6 +90,7 @@ export function setupViteNodeServerRpc(
     entry: string;
     rpcOrigin: string;
     debug?: boolean;
+    hmr?: boolean;
     viteNodeRunnerOptions: Partial<ViteNodeRunnerOptions>;
   }) {
     return {
@@ -111,6 +112,7 @@ export function setupViteNodeServerRpc(
         __VITE_NODE_SERVER_RPC_URL: options.rpcOrigin + rpcBase,
         __VITE_NODE_RUNNER_OPTIONS: options.viteNodeRunnerOptions as any,
         __VITE_NODE_DEBUG: options.debug ?? false,
+        __VITE_RUNTIME_HMR: options.hmr ?? false,
       },
     } satisfies MiniflareOptions;
   }