Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle功能增强和bugfix #724

Merged
merged 9 commits into from
May 4, 2020
Merged

Oracle功能增强和bugfix #724

merged 9 commits into from
May 4, 2020

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Apr 28, 2020

感谢@jan-song的贡献

关联PR: #701 #718
关联issue: #666 #700 #707

1、支持Oracle数据修改备份SQL功能,
2、支持explain,with查询语法
3、对Oracle表结构和schema显示进行排序,
4、支持sql tuning advisor
5、Oracle支持执行计划查看,
6、支持Oracle update/insert/delete/create table/create index的语法SQL审核

说明:
1、生成回滚SQL功能,执行用户需要有grant select any transaction 权限,需要有grant execute on dbms_logmnr 权限
2、生成回滚SQL功能,数据库需开启最小化附加日志alter database add supplemental log data;
3、生成回滚SQL功能,需为归档模式;开启附件日志会增加redo日志量,一般不会有多大影响,需评估归档磁盘空间,redo磁盘IO性能
4、sql tuning advisor需要grant advisor权限

@hhyo hhyo added area/oracle enhancement New feature or request labels Apr 28, 2020
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #724 into master will decrease coverage by 1.41%.
The diff coverage is 28.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   81.14%   79.73%   -1.42%     
==========================================
  Files          78       78              
  Lines       10502    11201     +699     
==========================================
+ Hits         8522     8931     +409     
- Misses       1980     2270     +290     
Impacted Files Coverage Δ
sql/urls.py 100.00% <ø> (ø)
sql/sql_optimize.py 58.04% <3.33%> (-11.40%) ⬇️
sql/utils/sql_utils.py 63.08% <25.00%> (-1.30%) ⬇️
sql/engines/oracle.py 49.70% <29.05%> (-40.82%) ⬇️
sql/engines/tests.py 99.59% <100.00%> (+<0.01%) ⬆️
sql/utils/execute_sql.py 86.20% <0.00%> (-2.17%) ⬇️
sql/sql_workflow.py 66.40% <0.00%> (-0.47%) ⬇️
sql/utils/tests.py 100.00% <0.00%> (ø)
sql/models.py 97.81% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac69c9...bad1d07. Read the comment docs.

@hhyo
Copy link
Owner Author

hhyo commented Apr 28, 2020

建议@ericruan-cn 有时间参与一下review,Oracle你那边使用的比较多

@ericruan-cn
Copy link
Collaborator

ericruan-cn commented Apr 28, 2020 via email

@hhyo hhyo merged commit afcc013 into master May 4, 2020
@hhyo
Copy link
Owner Author

hhyo commented May 4, 2020

已合并,有修改建议可再开pr

@hhyo hhyo deleted the oracle branch May 29, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oracle enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants