Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加系统字典模块 #364

Closed
wants to merge 1 commit into from
Closed

增加系统字典模块 #364

wants to merge 1 commit into from

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Aug 4, 2019

相关issue: #284

管理系统枚举定义信息

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #364 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   85.29%   85.32%   +0.02%     
==========================================
  Files          67       67              
  Lines        8822     8840      +18     
==========================================
+ Hits         7525     7543      +18     
  Misses       1297     1297
Impacted Files Coverage Δ
sql/models.py 95.11% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7929526...1b4719c. Read the comment docs.

@LeoQuote
Copy link
Collaborator

LeoQuote commented Aug 4, 2019

🤔️其实我没太理解系统字典是怎么和工单分类建立联系的

@hhyo
Copy link
Owner Author

hhyo commented Aug 5, 2019

实际上是把工单类型当做一个数据字典类型,比如叫做工单分类,然后这个字典类型包含上线工单、运维工单等字典值,就不用在代码内写死枚举值,只需要提交或者筛选时通过字典类型动态获取就可以

@LeoQuote
Copy link
Collaborator

LeoQuote commented Aug 5, 2019

那要不要考虑一下用已有的tag表

@hhyo
Copy link
Owner Author

hhyo commented Aug 5, 2019

可能和标签还是有点差异,标签是多对多的关系,字典表不仅仅给工单类型用,现有的那些枚举也可以接入进来

@LeoQuote
Copy link
Collaborator

LeoQuote commented Aug 8, 2019

突然感觉这个系统字典挺像k8s 的 configmap , 要不就作为一个本地配置文件, 反正改的频率也不高....

@hhyo
Copy link
Owner Author

hhyo commented Aug 8, 2019

@stale stale bot added the wontfix This will not be worked on label Aug 11, 2019
@LeoQuote LeoQuote added the enhancement New feature or request label Aug 11, 2019
@stale stale bot removed the wontfix This will not be worked on label Aug 11, 2019
Repository owner deleted a comment from stale bot Aug 11, 2019
@hhyo hhyo closed this Oct 31, 2020
@hhyo hhyo deleted the sys-dict branch October 31, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants