Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ 功能建议 ] DDL和DML拆分成2个审核流程 #902

Closed
gddezero opened this issue Oct 9, 2020 · 2 comments
Closed

[ 功能建议 ] DDL和DML拆分成2个审核流程 #902

gddezero opened this issue Oct 9, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@gddezero
Copy link

gddezero commented Oct 9, 2020

目前遇到的问题/使用障碍

目前SQL上线审核和执行由各个业务开发lead来做，发生过几次大表执行ddl时将meta table锁死的事故

希望如何解决/实现它

希望将DDL审核和执行和DML拆分成2个审核流程，DDL由DBA审核执行，DML由业务开发lead来审核执行

其他信息

无
@gddezero
Copy link
Author

gddezero commented Oct 9, 2020

这个功能的背景是DBA人手非常少，没有精力去审核执行所有的DDL和DML。这样的背景下，DBA主要把精力放在DDL的审核上，针对大表ddl，dba会使用pt-osc或ghost。很多开发没有这个意识，不清楚DDL可能会引起事故。
而DML可以由开发lead自行审核执行，毕竟开发最清楚DML的合理性和必要性。

@hhyo
Copy link
Owner

hhyo commented Oct 9, 2020

想法很好，不过容易解决一个问题又带来其他问题，可以考虑从权限下手，更细粒度的拆分执行权限

同时针对元数据锁goinception已经增加了限制，可以更新尝试，至少可以避免故障的产生

hanchuanchuan/goInception#224

hhyo added a commit that referenced this issue Oct 17, 2020
@hhyo
goInception 默认配置 lock_wait_timeout=10 #902
a1236f9
@hhyo hhyo added the enhancement New feature or request label Oct 20, 2020
hhyo added a commit that referenced this issue Oct 31, 2020
@hhyo
goInception 默认配置 lock_wait_timeout=10 #902
019b564
Repository owner locked and limited conversation to collaborators Jun 12, 2022
@hhyo hhyo converted this issue into discussion #1592 Jun 12, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hhyo @gddezero