Fix some shortcomings of UnusedParameterLinter #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Variadic parameters were not checked
function _(int ... $x): void {} now emits an error for $x.
- Lambda parameters are now linted in unparenthesized params.
$x ==> 0 now emits an error for $x.
Same applies for (int ... $x) ==> 0.
- Added explicit tests for old style variadics.
The linter handled them fine, but there was no test for it.
Checking for unparenthesized lambda parameters required a new linter.
The UnusedParameterLinter checked against ParameterDeclaration.
$x ==> 0; does not introduce one, so a new TNode was required.
This PR may cause old HHAST_FIXME comments to break.
You will have to upgrade:
/*HHAST_FIXME[UnusedParameter]*/ ($x) ==> 0; to
/*HHAST_FIXME[UnusedLambdaParameter]*/ ($x) ==> 0;
I suspect this linter is rarely suppressed, since the autofix is easier.
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function _(int ... $x): void {} now emits an error for $x.
$x ==> 0 now emits an error for $x.
Same applies for (int ... $x) ==> 0.
The linter handled them fine, but there was no test for it.
Checking for unparenthesized lambda parameters required a new linter.
The UnusedParameterLinter checked against ParameterDeclaration.
$x ==> 0; does not introduce one, so a new TNode was required.
This PR may cause old HHAST_FIXME comments to break.
You will have to upgrade:
/*HHAST_FIXME[UnusedParameter]*/ ($x) ==> 0; to
/*HHAST_FIXME[UnusedLambdaParameter]*/ ($x) ==> 0;
I suspect this linter is rarely suppressed, since the autofix is easier.