This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
Improve the commands to update schema #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `code` instead of `edit` given that the project has been opened in VS Code - Add `-y` to apt commands.
alexeyt
suggested changes
Apr 25, 2022
docs/updating-schema.md
Outdated
| 2. edit /etc/apt/sources.list - remove `-4.x` suffix from dl.hhvm.com repository | ||
| 3. apt update; apt remove hhvm; apt install hhvm-nightly (or `apt install hhvm` for latest stable release) | ||
| 1. Get a github codespace or use vscode devcontainers. If a codespace, pick the biggest one you can for this (in general, the smallest are good enough, but here more power is useful). | ||
| 2. `code /etc/apt/sources.list` - remove `-4.x` suffix from dl.hhvm.com repository |
There was a problem hiding this comment.
This change assumes people always use the vscode editor? IIUC Fred did not, and I certainly do not :-) I am OK with your chanbes to step 3 (adding -y), and I am OK removing step 1 (many editors are already available, if you want a non-default one it's up to you to install it), but I would like this step to remain as "edit /etc/apt/sources.list"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeinstead ofeditgiven that the project has been opened in VS Code-yto apt commands.