Add the File::errorCodesToSuppress method, which scans a source file for all lint markers
#384
Conversation
Atry
changed the title
lintMarkers method, which scans a source file for all lint markerslintMarkers method, which scans a source file for all lint markers
Atry
force-pushed
the
marker-scaner
branch
2 times, most recently
from
840371a
to
8ed09eb
Compare
Atry
force-pushed
the
marker-scaner
branch
2 times, most recently
from
c8aed9d
to
009b7b1
Compare
src/File.hack
Outdated
| * Returns the 1-base line number of lint markers in the file. | ||
| */ | ||
| <<__Memoize>> | ||
| public function lintMarkers(): dict<string, keyset<self::TLineNumber1Base>> { |
There was a problem hiding this comment.
lintMarkersForLineBasedSuppression
Not all linters should respect these, especially AST-based linters (they should require that the suppression be attached to the specific AST node).
That's probably the best for hh-client based linters; given ASTs are cached, it shoudln't be too wasteful. The position can be transformed to a node via HHAST\find_node_at_position() - and the AST identifies which comments correspond to which nodes.
if memoized, this does need sharing between linters, but it's not great for separation of concerns :(
There was a problem hiding this comment.
I am not sure if HHVM supports something similar to ES6 WeakMap to implement a non-intrusive cache.
There was a problem hiding this comment.
It's not worth to introduce some mechanism of Dependency Injection in this simple library.
We might be able to implement the Cake Pattern here, but Hack traits are more restrictive than Scala traits.
Probably there is no simple solution for separation of concerns here.
Atry
changed the title
lintMarkers method, which scans a source file for all lint markerslintMarkersForLineBasedSuppression method, which scans a source file for all lint markers
Atry
force-pushed
the
marker-scaner
branch
3 times, most recently
from
9915195
to
3562ba1
Compare
|
Does need green test run though |
Atry
force-pushed
the
marker-scaner
branch
3 times, most recently
from
300ee11
to
31652f1
Compare
… suppress according to lint markers in the file
Atry
changed the title
lintMarkersForLineBasedSuppression method, which scans a source file for all lint markersFile::errorCodesToSuppress method, which scans a source file for all lint markers
This dict returned by
lintMarkerscan be reused by all the linters, reducing repeated string search.