Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Add the configuration for a dev container #369

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Nov 4, 2021

This PR adds the configuration for a dev container, which could be used in the Visual Studio Code Remote - Containers extension.

@fredemmott
Copy link
Contributor

Heh, thanks, I was looking at this yesterday (https://github.com/fredemmott/hhast/blob/codespaces/.devcontainer.json) for GitHub Codespaces - though mine's untested as I wasn't aware vscode natively supported them.

Any preference or advantages/disadvantages for using a Dockerfile rather than using the original image with postCreateCommand for composer?

@Atry
Copy link
Contributor Author

Atry commented Nov 4, 2021

Any preference or advantages/disadvantages for using a Dockerfile rather than using the original image with postCreateCommand for composer?

Good idea! I just amended the commit as you suggested.

@Atry
Copy link
Contributor Author

Atry commented Nov 4, 2021

截屏2021-11-04 上午9 15 52

@fredemmott fredemmott merged commit 45c2f16 into hhvm:main Nov 4, 2021
@Atry Atry deleted the devcontainer branch November 4, 2021 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants