Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Known bad HHClientLinters need to be automatically unconditionally suppressed #408

Closed
fredemmott opened this issue Nov 26, 2021 · 5 comments
Closed

Known bad HHClientLinters need to be automatically unconditionally suppressed #408

fredemmott opened this issue Nov 26, 2021 · 5 comments

Comments

@fredemmott
Copy link
Contributor

See #368 (comment) and HackLintRule::HACK_LINT_IGNORED_CODES in FB www

This relates to #407 - we should never be raising 5583
@fredemmott fredemmott changed the title Known buggy HHClientLinters need to be automatically unconditioanlly suppressed Known buggy HHClientLinters need to be automatically unconditionally suppressed Nov 26, 2021
@fredemmott fredemmott mentioned this issue Nov 26, 2021
Closed
@fredemmott fredemmott changed the title Known buggy HHClientLinters need to be automatically unconditionally suppressed Known bad HHClientLinters need to be automatically unconditionally suppressed Nov 26, 2021
This was referenced Nov 26, 2021
Merged
Open
@lexidor
Copy link
Contributor

lexidor commented Nov 26, 2021

Is code 5607 (identity comparison on disjoint types) on that list?

fredemmott added a commit that referenced this issue Nov 26, 2021
@fredemmott
Remove HHClientLinter from NON_DEFAULT_LINTERS
63cf04d 
This enables it with the `all` option, but #408 and #409 are release blockers

It should be possible to enable this just for HHAST via `extraLinters` in the config, in a followup, but on vacation atm so doing the minimum here to get `main` back to a releasable state
@fredemmott fredemmott mentioned this issue Nov 26, 2021
Merged
@fredemmott
Copy link
Contributor Author

Nope, I think you found a new bug :)

@Atry
Copy link
Contributor

Atry commented Dec 9, 2021

This relates to #407 - we should never be raising 5583

I created #419 to ignore 5583

@Atry
Copy link
Contributor

Atry commented Dec 9, 2021

Fixed in #419 and #422

@Atry Atry closed this as completed Dec 9, 2021
@fredemmott
Copy link
Contributor Author

For reference, the other codes in the FB list are either already deleted from the Ocaml code, or are in the 6xxx range; the 6xxx range requires Zoncolan, which is sadly not open source :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredemmott @Atry @lexidor