Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Commit

Permalink
Suppress the 4323 typing error (#440)
Browse files Browse the repository at this point in the history
The original implementation is not type safe and there was an existing `HH_FIXME[4110]` marker to suppress the error. Unfortunately the marker is not adequate in the nightly HHVM because of the newly introduced 4323 error.
This PR suppresses the error 4323 and should fix the CI.
  • Loading branch information
Atry authored Mar 2, 2022
1 parent 6e1b3fa commit cade7dc
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/__Private/LintRunCLIEventHandler.hack
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,10 @@ final class LintRunCLIEventHandler implements LintRunEventHandler {
if ($fixing_linter) {
/* HHAST_IGNORE_ERROR[DontAwaitInALoop] */
$should_fix = await $this->shouldFixLintAsync(
/* HH_FIXME[4110] TError is lost here*/ $fixing_linter,
/* HH_FIXME[4110] TError is lost here*/ $error,
$fixing_linter,
/* HH_FIXME[4110] TError is lost here*/
/* HH_FIXME[4323] TError is lost here*/
$error,
);
if ($should_fix) {
$to_fix[] = $error;
Expand All @@ -103,7 +105,12 @@ final class LintRunCLIEventHandler implements LintRunEventHandler {

if (!C\is_empty($to_fix)) {
invariant($fixing_linter, "Can't fix without a fixing linter");
self::fixErrors(/* HH_FIXME[4110] TError is lost here */ $fixing_linter, $to_fix);
self::fixErrors(
$fixing_linter,
/* HH_FIXME[4110] TError is lost here */
/* HH_FIXME[4323] TError is lost here */
$to_fix
);
}

return $result;
Expand Down

0 comments on commit cade7dc

Please sign in to comment.