add compatible schema version (2020-11-02-0001)

hhvm · Nov 9, 2020 · 8c290db · 8c290db
1 parent ef14d3d
commit 8c290db
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/src/__Private/is_compatible_schema_version.hack b/src/__Private/is_compatible_schema_version.hack
@@ -33,13 +33,11 @@ function is_compatible_schema_version(string $other_version): bool {
 
   switch ($other_version) {
     // preceding versions:
-    case '2020-10-15-0001':
+    case '2020-10-15-0001': // missing enum-dependent type syntax
       return true;
-    /*
     // succeeding versions:
-    case 'version-number': // missing ...
+    case '2020-11-02-0001': // removes Pocket Universe syntax
       return true;
-    */
     default:
       return false;
   }

diff --git a/tests/PocketAtomExpressionLinterTest.hack b/tests/PocketAtomExpressionLinterTest.hack
@@ -13,10 +13,8 @@ final class PocketAtomExpressionLinterTest extends TestCase {
   use LinterTestTrait;
 
   protected function getLinter(string $file): PocketAtomExpressionLinter {
-    if (\version_compare(\HHVM_VERSION, '4.23.0') < 0) {
-      self::markTestSkipped(
-        'Pocket Universe tests are only relevant on HHVM 4.23+',
-      );
+    if (\HHVM_VERSION_ID >= 408300) {
+      self::markTestSkipped('Pocket Universe syntax was removed in HHVM 4.83');
     }
     return PocketAtomExpressionLinter::fromPath($file);
   }

diff --git a/tests/PocketIdentifierExpressionLinterTest.hack b/tests/PocketIdentifierExpressionLinterTest.hack
@@ -15,10 +15,8 @@ final class PocketIdentifierExpressionLinterTest extends TestCase {
   protected function getLinter(
     string $file,
   ): PocketIdentifierExpressionLinter {
-    if (\version_compare(\HHVM_VERSION, '4.23.0') < 0) {
-      self::markTestSkipped(
-        'Pocket Universe tests are only relevant on HHVM 4.23+',
-      );
+    if (\HHVM_VERSION_ID >= 408300) {
+      self::markTestSkipped('Pocket Universe syntax was removed in HHVM 4.83');
     }
     return PocketIdentifierExpressionLinter::fromPath($file);
   }