Add compatible schema, skip PHP array literals linter on 4.65

While I'm here, clean up old schema versions

src/Linters/NoPHPArrayLiteralsLinter.hack

@@ -15,6 +15,13 @@ final class NoPHPArrayLiteralsLinter extends AutoFixingASTLinter {
   const type TNode = IPHPArray;
   const type TContext = Script;
 
+  <<__Override>>
+  public static function shouldLintFile(File $_): bool {
+    // array literals are no longer in the parser
+    return \HHVM_VERSION_ID < 406500;
+  }
+
+
   <<__Override>>
   public function getLintErrorForNode(
     Script $_context,

src/__Private/is_compatible_schema_version.hack

@@ -9,7 +9,6 @@
 
 namespace Facebook\HHAST\__Private;
 
-use namespace HH\Lib\C;
 use const Facebook\HHAST\SCHEMA_VERSION;
 
 /**
@@ -21,59 +20,21 @@ use const Facebook\HHAST\SCHEMA_VERSION;
  * Facebook\HHAST\SCHEMA_VERSION.
  */
 function is_compatible_schema_version(string $other_version): bool {
+  invariant(
+    SCHEMA_VERSION === '2020-06-02-0001',
+    '%s needs updating',
+    __FILE__,
+  );
   if ($other_version === SCHEMA_VERSION) {
     return true;
   }
 
-  // Superset => subsets.
-  $compatible_versions = keyset[];
+  // Return true if $other_superset is a superset of SCHEMA_VERSION
 
-  switch (SCHEMA_VERSION) {
-    case '2019-05-20-0001': // is a superset of:
-      // Succeeding versions:
-      $compatible_versions[] = '2019-07-23-0001';
-      break;
-
-    case '2019-10-03-0001': // is a superset of:
-      // Preceding versions:
-      // This one doesn't have union/intersection typehints:
-      $compatible_versions[] = '2019-08-22-0001';
-      // Succeeding versions:
-      // This one doesn't have `break/continue <num>`:
-      $compatible_versions[] = '2019-10-08-0001';
-      // This one doesn't have `let` statement (unused experimental feature):
-      $compatible_versions[] = '2019-11-15-0001';
-      break;
-
-    case '2020-01-22-0001': // is a superset of:
-      // Preceding versions:
-      // This one doesn't have XHP token, function pointer syntax:
-      $compatible_versions[] = '2019-11-29-0001';
-      // This one also doesn't have Pocket Universe `reify` syntax:
-      $compatible_versions[] = '2019-11-15-0001';
-      // Succeeding versions:
-      // This one doesn't have square bracket array literals:
-      $compatible_versions[] = '2020-02-03-0001';
-      // This one disallows using "namespace" as an identifier:
-      $compatible_versions[] = '2020-02-19-0001';
-      // This one removes support for <?= (PHP echo tag):
-      $compatible_versions[] = '2020-03-24-0001';
-      // This one removes support for __halt_compiler():
-      $compatible_versions[] = '2020-03-31-0001';
-      // This one removes support for ? > (PHP markup close tag)
-      $compatible_versions[] = '2020-04-01-0001';
-      break;
-
-    case '2020-04-14-0002': // is a superset of:
-      // Preceding versions:
-      // This one doesn't support Pocket Universe enum attributes:
-      $compatible_versions[] = '2020-04-14-0001';
-      // This one doesn't support more than one Pocket Universe enum modifier
-      // (actually doesn't matter for HHAST, so identical to 2020-04-14-0001 as
-      // far as HHAST is concerned):
-      $compatible_versions[] = '2020-04-06-0001';
-      break;
+  if ($other_version === '2020-06-23-0001') {
+    // removal of array literals
+    return true;
   }
 
-  return C\contains($compatible_versions, $other_version);
+  return false;
 }

tests/NoPHPArrayLiteralsLinterTest.hack

@@ -13,6 +13,11 @@ final class NoPHPArrayLiteralsLinterTest extends TestCase {
   use AutoFixingLinterTestTrait<ASTLintError>;
 
   protected function getLinter(string $file): NoPHPArrayLiteralsLinter {
+    if (\HHVM_VERSION_ID >= 406500) {
+      self::markTestSkipped(
+        'PHP array literals are not supported in this version',
+      );
+    }
     return NoPHPArrayLiteralsLinter::fromPath($file);
   }