-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to jsp #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution 👍
I made one comment, can you confirm it?
language.go
Outdated
@@ -490,6 +491,7 @@ func NewDefinedLanguages() *DefinedLanguages { | |||
"JAI": NewLanguage("JAI", []string{"//"}, [][]string{{"/*", "*/"}}), | |||
"Janet": NewLanguage("Janet", []string{"#"}, [][]string{{"", ""}}), | |||
"Java": NewLanguage("Java", []string{"//"}, [][]string{{"/*", "*/"}}), | |||
"Jsp": NewLanguage("Jsp", []string{"//"}, [][]string{{"/*", "*/"}}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the Jsp
to an upper case?
"Jsp": NewLanguage("Jsp", []string{"//"}, [][]string{{"/*", "*/"}}), | |
"JSP": NewLanguage("JSP", []string{"//"}, [][]string{{"/*", "*/"}}), |
language.go
Outdated
@@ -156,6 +156,7 @@ var Exts = map[string]string{ | |||
"ipynb": "Jupyter Notebook", | |||
"jai": "JAI", | |||
"java": "Java", | |||
"jsp": "Jsp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"jsp": "Jsp", | |
"jsp": "JSP", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I have changed the Jsp
to an upper case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks
add support to jsp