Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to jsp #44

Merged
merged 2 commits into from
Mar 12, 2021
Merged

add support to jsp #44

merged 2 commits into from
Mar 12, 2021

Conversation

aohanhongzhi
Copy link

add support to jsp

Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

I made one comment, can you confirm it?

language.go Outdated
@@ -490,6 +491,7 @@ func NewDefinedLanguages() *DefinedLanguages {
"JAI": NewLanguage("JAI", []string{"//"}, [][]string{{"/*", "*/"}}),
"Janet": NewLanguage("Janet", []string{"#"}, [][]string{{"", ""}}),
"Java": NewLanguage("Java", []string{"//"}, [][]string{{"/*", "*/"}}),
"Jsp": NewLanguage("Jsp", []string{"//"}, [][]string{{"/*", "*/"}}),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the Jsp to an upper case?

Suggested change
"Jsp": NewLanguage("Jsp", []string{"//"}, [][]string{{"/*", "*/"}}),
"JSP": NewLanguage("JSP", []string{"//"}, [][]string{{"/*", "*/"}}),

language.go Outdated
@@ -156,6 +156,7 @@ var Exts = map[string]string{
"ipynb": "Jupyter Notebook",
"jai": "JAI",
"java": "Java",
"jsp": "Jsp",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"jsp": "Jsp",
"jsp": "JSP",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I have changed the Jsp to an upper case

@hhatto hhatto self-requested a review March 12, 2021 07:48
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks

@hhatto hhatto merged commit 82da1cf into hhatto:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants