Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitContainer: hash collision does not guarantee equality #877

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

crusaderky
Copy link
Contributor

Closes #876

@crusaderky
Copy link
Contributor Author

@jthielen @hgrecco ready for review and merge

@hgrecco
Copy link
Owner

hgrecco commented Sep 11, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 11, 2019
877: UnitContainer: hash collision does not guarantee equality r=hgrecco a=crusaderky

Closes #876

Co-authored-by: Guido Imperiale <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 11, 2019

Build succeeded

@bors bors bot merged commit 0a84c83 into hgrecco:master Sep 11, 2019
@jthielen
Copy link
Contributor

Thank you for taking care of this so quickly! The affected tests in MetPy are passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in compound unit dimensionality/unit reduction after caching?
3 participants