Fix for issue #506 #542
Closed
Fix for issue #506 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 19, 2017
540: Update list of similar units implementations r=hgrecco I added astropy.units and yt, as those were missing from the list. Speaking of which, has there been any talk of maybe combining some of these packages? It feels a bit like the number of these is growing exponentially. 542: Fix for issue #506 r=hgrecco This changes the spelling of **millennium** in the default definition file, raised by issue #506 . It is a breaking change for anything that was defined with the misspelled version, as these versions of the unit were removed. To maintain backwards compatibility, these could be added back as aliases. It also has not been changed in the default_en_0.6 definition file.
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Aug 19, 2017
542: Fix for issue #506 r=hgrecco This changes the spelling of **millennium** in the default definition file, raised by issue #506 . It is a breaking change for anything that was defined with the misspelled version, as these versions of the unit were removed. To maintain backwards compatibility, these could be added back as aliases. It also has not been changed in the default_en_0.6 definition file.
Build failed |
|
Fixed by #811 a few months ago; please close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the spelling of millennium in the default definition file, raised by issue #506 . It is a breaking change for anything that was defined with the misspelled version, as these versions of the unit were removed. To maintain backwards compatibility, these could be added back as aliases. It also has not been changed in the default_en_0.6 definition file.