Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NEP18 overrides for max, min, and round #1721

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Mar 7, 2023

numpy recently changed the names of amin and amax to min and max, with the old names being kept around as aliases. However, that means that we need to override both until numpy<1.25 drops out of support (which will be a while, considering that numpy=1.25 has not been released yet).

Additionally, round_ has been deprecated in favor of round.

The test coverage has already been sufficient (we didn't get errors in CI because we don't test numpy dev), but I changed the round tests to not use the deprecated name.

  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate

@jules-ch
Copy link
Collaborator

Thanks

@keewis keewis deleted the numpy-1.25 branch March 24, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants