add NEP18 overrides for max
, min
, and round
#1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy
recently changed the names ofamin
andamax
tomin
andmax
, with the old names being kept around as aliases. However, that means that we need to override both untilnumpy<1.25
drops out of support (which will be a while, considering thatnumpy=1.25
has not been released yet).Additionally,
round_
has been deprecated in favor ofround
.The test coverage has already been sufficient (we didn't get errors in CI because we don't test
numpy
dev), but I changed theround
tests to not use the deprecated name.pre-commit run --all-files
with no errorsThe change is fully covered by automated unit testsDocumented in docs/ as appropriate