Hgctpg module id fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbsauvan
reviewed
Feb 16, 2022
| @@ -94,7 +94,7 @@ class HGCalTriggerModuleDetId : public DetId { | |||
| static const int kHGCalLayerMask = 0x1F; | |||
| static const int kHGCalTypeOffset = 19; | |||
| static const int kHGCalTypeMask = 0x3; | |||
| static const int kHGCalZsideOffset = 24; | |||
| static const int kHGCalZsideOffset = 21; | |||
There was a problem hiding this comment.
This change is already included in the dev branch (but your commit has been rebased on the dev branch, which is probably why it appears again here as a different commit).
Could you rebase (or cherry-pick) just the second commit on top of the dev branch?
portalesHEP
force-pushed
the
hgctpg_moduleIdFix
branch
from
49a2653 to
0019a52
Compare
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
The classID of HGalTriggerBackendDetId objects is now set properly to
HGCalTriggerClassIdentifier::BackendDetIdinstead ofHGCalTriggerClassIdentifier::ModuleDetId