-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to not send responses when the handler has already called finish() #108
Open
vivekfantain
wants to merge
6
commits into
hfaran:master
Choose a base branch
from
vivekfantain:1.3.3_local
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y called finished(). This is useful for HTTP 304 implementation
Hmm, not sure if the test failures here are related to your change; maybe a breaking change in jsonschema. I'll take a look. |
hfaran
changed the title
1.3.3 local
Added support to not send responses when the handler has already called finish()
Apr 17, 2019
@vivekfantain I just pushed #111 which pins some dependencies to fix the failing tests. Can you merge from the latest upstream master? That should fix it. |
Now I have a new issue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug that caused Tornado to fail because we are sending message after calling finished(). I had submitted an earlier patch that didn't pass tests. This version should. Hopefully!