Move hex.key tasks to hex.user #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/hexpm/hex/pulls/334. |
|
@milmazz glad to see you contributing to hex! ❤️ 💚 💙 💛 💜 |
ericmj
requested changes
Dec 26, 2016
|
|
||
| case args do | ||
| ["register"] -> | ||
| case OptionParser.parse(args, switches: @switches) do |
There was a problem hiding this comment.
I prefer to not do this because it means the whole case needs to be changed back if we add flags that can be used at the same time.
milmazz
force-pushed
the
move_hex.key_to_hex.user
branch
from
b62ed34 to
836c060
Compare
|
@josevalim Thanks! @ericmj I already made the changes that you requested, please let me know what do you think. |
ericmj
reviewed
Dec 26, 2016
|
|
||
| Lists all API keys associated with your account. | ||
|
|
||
| mix hex.user key --list-keys |
There was a problem hiding this comment.
The final -keys is redundant :).
There was a problem hiding this comment.
@ericmj Good catch! Already fixed.
milmazz
force-pushed
the
move_hex.key_to_hex.user
branch
from
836c060 to
727026f
Compare
milmazz
force-pushed
the
move_hex.key_to_hex.user
branch
from
727026f to
7e18935
Compare
ericmj
approved these changes
Dec 27, 2016
wojtekmach
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #305 /cc @josevalim @ericmj