Changed hex.outdated to show if a dependency can be updated #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now takes all dependent packages into account and simply prints a Yes or a No for outdated packages. Fixes hexpm#322
|
Build fails for OTP 17.5 with errors that seem unrelated to my changes. Is that expected? |
Not expected, but it doesn't seem to be related to your changes :). |
ericmj
requested changes
Dec 5, 2016
| @@ -1,5 +1,8 @@ | |||
| ## v0.14.2-dev | |||
|
|
|||
| ### Bug fixes | |||
| * mix hex.outdated correctly tests if a package can be updated | |||
|
|
|||
There was a problem hiding this comment.
You can leave it but in the future please don't change the changelog because it easily causes merge conflicts.
| deps | ||
| |> get_requirements(dep.app) | ||
| |> Enum.map(fn [_, req_version] -> req_version end) | ||
| |> List.insert_at(0, dep.requirement) |
There was a problem hiding this comment.
I would do [dep.requirement|requirements] instead but you can leave as-is.
There was a problem hiding this comment.
I agree that this is a bit ugly. Will change.
ericmj
approved these changes
Dec 5, 2016
|
Looking for one more review. /cc @wojtekmach |
wojtekmach
approved these changes
Dec 17, 2016
|
Thank you! |
|
💗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now takes all dependent packages into account and simply prints a
Yesor aNofor outdated packages.Fixes #322
The added test would show with a green "Requirement" before this update, even though it can't be updated.